SourceForge.net
2007-04-05 22:49:18 UTC
Patches item #1668681, was opened at 2007-02-26 02:23
Message generated for change (Comment added) made by shlomil
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1668681&group_id=235
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Shlomi Loubaton (shlomil)
Assigned to: Ethan Blanton (eblanton)
Summary: Close bug #1121620 and fix some Bi-Directional text issues
Initial Comment:
In this patch I implemented the following:
* Added a support for tag in the parser of the IMHtml Widget. (AFAIK this HTML tag is deprecated, but most browsers implement it and it beats coding CSS support)
* Added text direction detection to outgoing messages and send it with the correct SPAN tag.
* Added support for the "FN=1" flag in Messanger protocol implementation, both in sending and receiving messages (bug #1121620).
* Fixed some display issues: Insert RLM and RLE unicode characters to the conversation display according to the expected alignment and direction.
For more information about this patch and screenshots:
http://shlomil.blogspot.com/2007/02/patch-to-fix-some-bidi-text-issues-in.html
----------------------------------------------------------------------
Message:
Logged In: YES
user_id=953881
Originator: YES
4th version of the patch:
The problem mentioned in my previous comment with ICQ plug-in was fixed.
The function gaim_unescape_html() was used (oscar.c:4288) to strip HTML
tags before sending ch2 messages.
Doing that, of course, did not work so I changed it to use
gaim_markup_strip_html() .
File Added: shlomi-bidi4.patch
----------------------------------------------------------------------
Comment By: Shlomi Loubaton (shlomil)
Date: 2007-03-24 16:41
Message:
Logged In: YES
user_id=953881
Originator: YES
I investigated implementing the same fix for ICQ protocol only to realized
that it's impossible at least until the ability to send "channel 2"
messages is implemented in Gaim (AKA the 4 years old feature request
#787993). I guess that it's a heavy task since it requires implementing
basic RTF parsing abilities. After we have such ability - it's only a
matter of sending the message with this RTF prefix: '\pard\rtlpar\qr'.
Unfortunately, I also found a problem with the patch - sending a RTL
message to ICQ user will send embedded SPAN tags in the message. Seems like
ICQ's implementation rely on the fact that the message formatting buttons
are disabled when editing a message for ICQ and it doesn't strip the HTML
before sending. This is a minor fix - I'll fix it soon and upload a 4th
version for the patch.
----------------------------------------------------------------------
Comment By: Shlomi Loubaton (shlomil)
Date: 2007-03-06 23:59
Message:
Logged In: YES
user_id=953881
Originator: YES
* Timestamps and Aliases are now encapsulated in their own LRE/RLE Unicode
characters.
* screenshot of fixed timestamps in Gaim:
Loading Image...
Code just got a little more complicated but works great.
Maybe I should try to optimize it somehow. Suggestions/requests are
welcomed.
File Added: shlomi-bidi3.patch
----------------------------------------------------------------------
Comment By: Shlomi Loubaton (shlomil)
Date: 2007-03-02 03:38
Message:
Logged In: YES
user_id=953881
Originator: YES
Ok, thank you both. Note taken.
I'll see what I can do about the timestamps.
Shlomil.
----------------------------------------------------------------------
Comment By: Richard Laager (rlaager)
Date: 2007-03-02 02:40
Message:
Logged In: YES
user_id=156487
Originator: NO
I agree with Sean. As you can see in your second screenshot, the
timestamps don't line up. They should be on the right, with the name after
them (on the left, since we're talking about RTL).
----------------------------------------------------------------------
Comment By: Shlomi Loubaton (shlomil)
Date: 2007-03-02 01:45
Message:
Logged In: YES
user_id=953881
Originator: YES
Changes in shlomi-bidi2.patch:
* The two spans were unified to a single span tag (as Etan suggested).
* Now text properties are set by inline CSS attributes (<span
style="...">) (also as Etan suggested).
* Need for inline CSS parsing in MSN plug-in made this patch a little more
complicated than the first one.
* gtk_imhtml_get_css_opt() - Function was able to recognized only the
first attribute - now fixed. (But this function is a mess and should be
rewritten IMO)
Tested again talking to MSN Messenger and Gaim and it still works as
expected.
Shlomil.
----------------------------------------------------------------------
Comment By: Sean Egan (seanegan)
Date: 2007-03-02 01:44
Message:
Logged In: YES
user_id=199625
Originator: NO
I don't speak an rtl language, but it seems like, in the second
screenshot, you'd want the timestamp to be right-aligned, followed by the
screenname, then the message. Like we do it in LTR.
----------------------------------------------------------------------
Comment By: Shlomi Loubaton (shlomil)
Date: 2007-03-02 01:27
Message:
Logged In: YES
user_id=953881
Originator: YES
File Added: shlomi-bidi2.patch
----------------------------------------------------------------------
Comment By: Shlomi Loubaton (shlomil)
Date: 2007-02-28 08:39
Message:
Logged In: YES
user_id=953881
Originator: YES
After a chat with Etan on IRC, I was suggested to unify the two span tags
into one tag and add the alignment and direction attributes (deprecated
HTML) as CSS properties.
I'll do that and then resubmit my patch.
----------------------------------------------------------------------
Comment By: Luke Schierer (lschiere)
Date: 2007-02-27 22:40
Message:
Logged In: YES
user_id=28833
Originator: NO
Ethan, do you have time to look at this?
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1668681&group_id=235
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
Message generated for change (Comment added) made by shlomil
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1668681&group_id=235
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Shlomi Loubaton (shlomil)
Assigned to: Ethan Blanton (eblanton)
Summary: Close bug #1121620 and fix some Bi-Directional text issues
Initial Comment:
In this patch I implemented the following:
* Added a support for tag in the parser of the IMHtml Widget. (AFAIK this HTML tag is deprecated, but most browsers implement it and it beats coding CSS support)
* Added text direction detection to outgoing messages and send it with the correct SPAN tag.
* Added support for the "FN=1" flag in Messanger protocol implementation, both in sending and receiving messages (bug #1121620).
* Fixed some display issues: Insert RLM and RLE unicode characters to the conversation display according to the expected alignment and direction.
For more information about this patch and screenshots:
http://shlomil.blogspot.com/2007/02/patch-to-fix-some-bidi-text-issues-in.html
----------------------------------------------------------------------
Comment By: Shlomi Loubaton (shlomil)
Date: 2007-04-05 22:49Message:
Logged In: YES
user_id=953881
Originator: YES
4th version of the patch:
The problem mentioned in my previous comment with ICQ plug-in was fixed.
The function gaim_unescape_html() was used (oscar.c:4288) to strip HTML
tags before sending ch2 messages.
Doing that, of course, did not work so I changed it to use
gaim_markup_strip_html() .
File Added: shlomi-bidi4.patch
----------------------------------------------------------------------
Comment By: Shlomi Loubaton (shlomil)
Date: 2007-03-24 16:41
Message:
Logged In: YES
user_id=953881
Originator: YES
I investigated implementing the same fix for ICQ protocol only to realized
that it's impossible at least until the ability to send "channel 2"
messages is implemented in Gaim (AKA the 4 years old feature request
#787993). I guess that it's a heavy task since it requires implementing
basic RTF parsing abilities. After we have such ability - it's only a
matter of sending the message with this RTF prefix: '\pard\rtlpar\qr'.
Unfortunately, I also found a problem with the patch - sending a RTL
message to ICQ user will send embedded SPAN tags in the message. Seems like
ICQ's implementation rely on the fact that the message formatting buttons
are disabled when editing a message for ICQ and it doesn't strip the HTML
before sending. This is a minor fix - I'll fix it soon and upload a 4th
version for the patch.
----------------------------------------------------------------------
Comment By: Shlomi Loubaton (shlomil)
Date: 2007-03-06 23:59
Message:
Logged In: YES
user_id=953881
Originator: YES
* Timestamps and Aliases are now encapsulated in their own LRE/RLE Unicode
characters.
* screenshot of fixed timestamps in Gaim:
Loading Image...
Code just got a little more complicated but works great.
Maybe I should try to optimize it somehow. Suggestions/requests are
welcomed.
File Added: shlomi-bidi3.patch
----------------------------------------------------------------------
Comment By: Shlomi Loubaton (shlomil)
Date: 2007-03-02 03:38
Message:
Logged In: YES
user_id=953881
Originator: YES
Ok, thank you both. Note taken.
I'll see what I can do about the timestamps.
Shlomil.
----------------------------------------------------------------------
Comment By: Richard Laager (rlaager)
Date: 2007-03-02 02:40
Message:
Logged In: YES
user_id=156487
Originator: NO
I agree with Sean. As you can see in your second screenshot, the
timestamps don't line up. They should be on the right, with the name after
them (on the left, since we're talking about RTL).
----------------------------------------------------------------------
Comment By: Shlomi Loubaton (shlomil)
Date: 2007-03-02 01:45
Message:
Logged In: YES
user_id=953881
Originator: YES
Changes in shlomi-bidi2.patch:
* The two spans were unified to a single span tag (as Etan suggested).
* Now text properties are set by inline CSS attributes (<span
style="...">) (also as Etan suggested).
* Need for inline CSS parsing in MSN plug-in made this patch a little more
complicated than the first one.
* gtk_imhtml_get_css_opt() - Function was able to recognized only the
first attribute - now fixed. (But this function is a mess and should be
rewritten IMO)
Tested again talking to MSN Messenger and Gaim and it still works as
expected.
Shlomil.
----------------------------------------------------------------------
Comment By: Sean Egan (seanegan)
Date: 2007-03-02 01:44
Message:
Logged In: YES
user_id=199625
Originator: NO
I don't speak an rtl language, but it seems like, in the second
screenshot, you'd want the timestamp to be right-aligned, followed by the
screenname, then the message. Like we do it in LTR.
----------------------------------------------------------------------
Comment By: Shlomi Loubaton (shlomil)
Date: 2007-03-02 01:27
Message:
Logged In: YES
user_id=953881
Originator: YES
File Added: shlomi-bidi2.patch
----------------------------------------------------------------------
Comment By: Shlomi Loubaton (shlomil)
Date: 2007-02-28 08:39
Message:
Logged In: YES
user_id=953881
Originator: YES
After a chat with Etan on IRC, I was suggested to unify the two span tags
into one tag and add the alignment and direction attributes (deprecated
HTML) as CSS properties.
I'll do that and then resubmit my patch.
----------------------------------------------------------------------
Comment By: Luke Schierer (lschiere)
Date: 2007-02-27 22:40
Message:
Logged In: YES
user_id=28833
Originator: NO
Ethan, do you have time to look at this?
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1668681&group_id=235
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV